zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From an...@apache.org
Subject zookeeper git commit: ZOOKEEPER-3159: Flaky: ClientRequestTimeoutTest.testClientRequestTimeout
Date Fri, 12 Oct 2018 08:28:34 GMT
Repository: zookeeper
Updated Branches:
  refs/heads/master ee250f141 -> 6285f332a


ZOOKEEPER-3159: Flaky: ClientRequestTimeoutTest.testClientRequestTimeout

Can't see a reason why testing again the create method without packet drop. Timeout scenario
has already been tested and this part seem to make the test flaky. Removed.

Author: Andor Molnar <andor@apache.org>

Reviewers: nkalmar@cloudera.com, andor@apache.org

Closes #653 from anmolnar/ZOOKEEPER-3159


Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/6285f332
Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/6285f332
Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/6285f332

Branch: refs/heads/master
Commit: 6285f332a78f62272114b0f21e74b559974326ef
Parents: ee250f1
Author: Andor Molnar <andor@apache.org>
Authored: Fri Oct 12 10:28:29 2018 +0200
Committer: Andor Molnar <andor@apache.org>
Committed: Fri Oct 12 10:28:29 2018 +0200

----------------------------------------------------------------------
 .../java/org/apache/zookeeper/ClientRequestTimeoutTest.java  | 8 --------
 1 file changed, 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zookeeper/blob/6285f332/zookeeper-common/src/test/java/org/apache/zookeeper/ClientRequestTimeoutTest.java
----------------------------------------------------------------------
diff --git a/zookeeper-common/src/test/java/org/apache/zookeeper/ClientRequestTimeoutTest.java
b/zookeeper-common/src/test/java/org/apache/zookeeper/ClientRequestTimeoutTest.java
index 4f5548d..8fcc371 100644
--- a/zookeeper-common/src/test/java/org/apache/zookeeper/ClientRequestTimeoutTest.java
+++ b/zookeeper-common/src/test/java/org/apache/zookeeper/ClientRequestTimeoutTest.java
@@ -92,14 +92,6 @@ public class ClientRequestTimeoutTest extends QuorumPeerTestBase {
             assertEquals(KeeperException.Code.REQUESTTIMEOUT.intValue(),
                     exception.code().intValue());
         }
-        // reset the error behavior
-        dropPacket = false;
-        watch1.waitForConnected(ClientBase.CONNECTION_TIMEOUT);
-
-        String path = "/clientHang3";
-        String create = zk.create(path, data.getBytes(), Ids.OPEN_ACL_UNSAFE,
-                CreateMode.PERSISTENT);
-        assertEquals(path, create);
 
         // do cleanup
         zk.close();


Mime
View raw message