zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ph...@apache.org
Subject zookeeper git commit: ZOOKEEPER-2795: Change log level for "ZKShutdownHandler is not registered" error message
Date Tue, 21 Nov 2017 17:38:45 GMT
Repository: zookeeper
Updated Branches:
  refs/heads/master f299303ad -> b5621c698


ZOOKEEPER-2795: Change log level for "ZKShutdownHandler is not registered" error message

`ZKShutdownHandler` may not be registered if the user creates a `ZooKeeperServer` object outside
of `ZooKeeperServerMain.runFromConfig`.

We should change the log level of the message that is printed on state changes of `ZooKeeperServer`
when `ZKShutdownHandler` is missing to something lower.

Author: Abraham Fine <afine@apache.org>

Reviewers: phunt@apache.org

Closes #273 from afine/ZOOKEEPER-2795

Change-Id: I8b048f6b79870064325925a6ff52f7d1f3e5e1da
(cherry picked from commit 86e35b5ae4e846e84dcc3ec08f724af7aa4ec2aa)
Signed-off-by: Patrick Hunt <phunt@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/b5621c69
Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/b5621c69
Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/b5621c69

Branch: refs/heads/master
Commit: b5621c698baf5d3258ebcf9342a23aa4889d03ca
Parents: f299303
Author: Abraham Fine <afine@apache.org>
Authored: Tue Nov 21 09:37:24 2017 -0800
Committer: Patrick Hunt <phunt@apache.org>
Committed: Tue Nov 21 09:38:20 2017 -0800

----------------------------------------------------------------------
 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zookeeper/blob/b5621c69/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
----------------------------------------------------------------------
diff --git a/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java b/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
index 59fd25d..11b6981 100644
--- a/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
+++ b/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
@@ -506,7 +506,7 @@ public class ZooKeeperServer implements SessionExpirer, ServerStats.Provider
{
         if (zkShutdownHandler != null) {
             zkShutdownHandler.handle(state);
         } else {
-            LOG.error("ZKShutdownHandler is not registered, so ZooKeeper server "
+            LOG.debug("ZKShutdownHandler is not registered, so ZooKeeper server "
                     + "won't take any action on ERROR or SHUTDOWN server state changes");
         }
     }


Mime
View raw message