Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E9B18200D16 for ; Tue, 10 Oct 2017 20:50:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E82C4160BE0; Tue, 10 Oct 2017 18:50:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3A8501609CB for ; Tue, 10 Oct 2017 20:50:47 +0200 (CEST) Received: (qmail 28793 invoked by uid 500); 10 Oct 2017 18:50:46 -0000 Mailing-List: contact commits-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list commits@zookeeper.apache.org Received: (qmail 28781 invoked by uid 99); 10 Oct 2017 18:50:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Oct 2017 18:50:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 492A0F5753; Tue, 10 Oct 2017 18:50:46 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: phunt@apache.org To: commits@zookeeper.apache.org Message-Id: <422504373c5d48e7b195dd80ef40d674@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: zookeeper git commit: ZOOKEEPER-2890: Local automatic variable is left uninitialized and then freed. Date: Tue, 10 Oct 2017 18:50:46 +0000 (UTC) archived-at: Tue, 10 Oct 2017 18:50:48 -0000 Repository: zookeeper Updated Branches: refs/heads/master 194f43e74 -> 43a50ebc6 ZOOKEEPER-2890: Local automatic variable is left uninitialized and then freed. Fixes https://issues.apache.org/jira/browse/ZOOKEEPER-2890 Author: xoiss Reviewers: Patrick Hunt Closes #359 from xoiss/branch-3.4-bugfix-zookeeper-2890 Change-Id: Ib3d132fc812a62b720967a888aff28edb7f3bdf1 (cherry picked from commit 948766de31eb955d62e661b7c55b74aa64434c77) Signed-off-by: Patrick Hunt Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/43a50ebc Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/43a50ebc Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/43a50ebc Branch: refs/heads/master Commit: 43a50ebc658dd25b8b9f9f91cf4c32c2c0e3e000 Parents: 194f43e Author: xoiss Authored: Tue Oct 10 11:41:21 2017 -0700 Committer: Patrick Hunt Committed: Tue Oct 10 11:50:22 2017 -0700 ---------------------------------------------------------------------- src/c/src/zookeeper.c | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zookeeper/blob/43a50ebc/src/c/src/zookeeper.c ---------------------------------------------------------------------- diff --git a/src/c/src/zookeeper.c b/src/c/src/zookeeper.c index 8c77243..af52572 100644 --- a/src/c/src/zookeeper.c +++ b/src/c/src/zookeeper.c @@ -2675,6 +2675,7 @@ static void deserialize_response(zhandle_t *zh, int type, int xid, int failed, i cptr->c.string_result(rc, 0, cptr->data); } else { struct CreateResponse res; + memset(&res, 0, sizeof(res)); deserialize_CreateResponse(ia, "reply", &res); cptr->c.string_result(rc, res.path, cptr->data); deallocate_CreateResponse(&res);