Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 34980200BF3 for ; Thu, 5 Jan 2017 22:33:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3336C160B42; Thu, 5 Jan 2017 21:33:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 84D49160B33 for ; Thu, 5 Jan 2017 22:33:04 +0100 (CET) Received: (qmail 21218 invoked by uid 500); 5 Jan 2017 21:33:03 -0000 Mailing-List: contact commits-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list commits@zookeeper.apache.org Received: (qmail 21207 invoked by uid 99); 5 Jan 2017 21:33:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2017 21:33:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 79F53DF9E6; Thu, 5 Jan 2017 21:33:03 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: hanm@apache.org To: commits@zookeeper.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: zookeeper git commit: ZOOKEEPER-2620: Add comments to testReadOnlySnapshotDir and testReadOnlyTxnLogDir indicating that the tests will fail when run as root Date: Thu, 5 Jan 2017 21:33:03 +0000 (UTC) archived-at: Thu, 05 Jan 2017 21:33:05 -0000 Repository: zookeeper Updated Branches: refs/heads/branch-3.4 8b75543a5 -> b7873a594 ZOOKEEPER-2620: Add comments to testReadOnlySnapshotDir and testReadOnlyTxnLogDir indicating that the tests will fail when run as root Author: Abraham Fine Reviewers: Michael Han Closes #142 from afine/ZOOKEEPER-2620 Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/b7873a59 Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/b7873a59 Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/b7873a59 Branch: refs/heads/branch-3.4 Commit: b7873a59433b252c54c6c926cda711a6abf55374 Parents: 8b75543 Author: Abraham Fine Authored: Thu Jan 5 13:32:53 2017 -0800 Committer: Michael Han Committed: Thu Jan 5 13:32:53 2017 -0800 ---------------------------------------------------------------------- .../zookeeper/server/ZooKeeperServerMainTest.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/zookeeper/blob/b7873a59/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---------------------------------------------------------------------- diff --git a/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java b/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java index aa94fb6..2ffb91e 100644 --- a/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java +++ b/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java @@ -207,6 +207,12 @@ public class ZooKeeperServerMainTest extends ZKTestCase implements Watcher { main.deleteDirs(); } + /** + * Tests that the ZooKeeper server will fail to start if the + * snapshot directory is read only. + * + * This test will fail if it is executed as root user. + */ @Test(timeout = 30000) public void testReadOnlySnapshotDir() throws Exception { ClientBase.setupTestEnv(); @@ -241,6 +247,12 @@ public class ZooKeeperServerMainTest extends ZKTestCase implements Watcher { main.deleteDirs(); } + /** + * Tests that the ZooKeeper server will fail to start if the + * transaction log directory is read only. + * + * This test will fail if it is executed as root user. + */ @Test(timeout = 30000) public void testReadOnlyTxnLogDir() throws Exception { ClientBase.setupTestEnv();