zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From h...@apache.org
Subject zookeeper git commit: ZOOKEEPER-2620: Add comments to testReadOnlySnapshotDir and testReadOnlyTxnLogDir indicating that the tests will fail when run as root
Date Thu, 05 Jan 2017 21:33:03 GMT
Repository: zookeeper
Updated Branches:
  refs/heads/branch-3.4 8b75543a5 -> b7873a594


ZOOKEEPER-2620: Add comments to testReadOnlySnapshotDir and testReadOnlyTxnLogDir indicating
that the tests will fail when run as root

Author: Abraham Fine <afine@apache.org>

Reviewers: Michael Han <hanm@apache.org>

Closes #142 from afine/ZOOKEEPER-2620


Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/b7873a59
Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/b7873a59
Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/b7873a59

Branch: refs/heads/branch-3.4
Commit: b7873a59433b252c54c6c926cda711a6abf55374
Parents: 8b75543
Author: Abraham Fine <afine@apache.org>
Authored: Thu Jan 5 13:32:53 2017 -0800
Committer: Michael Han <hanm@apache.org>
Committed: Thu Jan 5 13:32:53 2017 -0800

----------------------------------------------------------------------
 .../zookeeper/server/ZooKeeperServerMainTest.java       | 12 ++++++++++++
 1 file changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zookeeper/blob/b7873a59/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
----------------------------------------------------------------------
diff --git a/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java b/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
index aa94fb6..2ffb91e 100644
--- a/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
+++ b/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
@@ -207,6 +207,12 @@ public class ZooKeeperServerMainTest extends ZKTestCase implements Watcher
{
         main.deleteDirs();
     }
 
+    /**
+     * Tests that the ZooKeeper server will fail to start if the
+     * snapshot directory is read only.
+     *
+     * This test will fail if it is executed as root user.
+     */
     @Test(timeout = 30000)
     public void testReadOnlySnapshotDir() throws Exception {
         ClientBase.setupTestEnv();
@@ -241,6 +247,12 @@ public class ZooKeeperServerMainTest extends ZKTestCase implements Watcher
{
         main.deleteDirs();
     }
 
+    /**
+     * Tests that the ZooKeeper server will fail to start if the
+     * transaction log directory is read only.
+     *
+     * This test will fail if it is executed as root user.
+     */
     @Test(timeout = 30000)
     public void testReadOnlyTxnLogDir() throws Exception {
         ClientBase.setupTestEnv();


Mime
View raw message