zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From h...@apache.org
Subject zookeeper git commit: ZOOKEEPER-2620: Add comments to testReadOnlySnapshotDir and testReadOnlyTxnLogDir indicating that the tests will fail when run as root
Date Thu, 05 Jan 2017 21:33:23 GMT
Repository: zookeeper
Updated Branches:
  refs/heads/master 670bb5d5e -> 0753f4cdc


ZOOKEEPER-2620: Add comments to testReadOnlySnapshotDir and testReadOnlyTxnLogDir indicating
that the tests will fail when run as root

Author: Abraham Fine <afine@apache.org>

Reviewers: Michael Han <hanm@apache.org>

Closes #142 from afine/ZOOKEEPER-2620

(cherry picked from commit b7873a59433b252c54c6c926cda711a6abf55374)
Signed-off-by: Michael Han <hanm@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/zookeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/zookeeper/commit/0753f4cd
Tree: http://git-wip-us.apache.org/repos/asf/zookeeper/tree/0753f4cd
Diff: http://git-wip-us.apache.org/repos/asf/zookeeper/diff/0753f4cd

Branch: refs/heads/master
Commit: 0753f4cdceaa2e5386072d129d897417da47d959
Parents: 670bb5d
Author: Abraham Fine <afine@apache.org>
Authored: Thu Jan 5 13:32:53 2017 -0800
Committer: Michael Han <hanm@apache.org>
Committed: Thu Jan 5 13:33:20 2017 -0800

----------------------------------------------------------------------
 .../zookeeper/server/ZooKeeperServerMainTest.java       | 12 ++++++++++++
 1 file changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zookeeper/blob/0753f4cd/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
----------------------------------------------------------------------
diff --git a/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java b/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
index 1030209..01b6560 100644
--- a/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
+++ b/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java
@@ -202,6 +202,12 @@ public class ZooKeeperServerMainTest extends ZKTestCase implements Watcher
{
         main.deleteDirs();
     }
 
+    /**
+     * Tests that the ZooKeeper server will fail to start if the
+     * snapshot directory is read only.
+     *
+     * This test will fail if it is executed as root user.
+     */
     @Test(timeout = 30000)
     public void testReadOnlySnapshotDir() throws Exception {
         ClientBase.setupTestEnv();
@@ -236,6 +242,12 @@ public class ZooKeeperServerMainTest extends ZKTestCase implements Watcher
{
         main.deleteDirs();
     }
 
+    /**
+     * Tests that the ZooKeeper server will fail to start if the
+     * transaction log directory is read only.
+     *
+     * This test will fail if it is executed as root user.
+     */
     @Test(timeout = 30000)
     public void testReadOnlyTxnLogDir() throws Exception {
         ClientBase.setupTestEnv();


Mime
View raw message