zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maha...@apache.org
Subject svn commit: r1381895 - in /zookeeper/branches/branch-3.4: CHANGES.txt src/contrib/zkperl/ZooKeeper.xs
Date Fri, 07 Sep 2012 06:13:38 GMT
Author: mahadev
Date: Fri Sep  7 06:13:38 2012
New Revision: 1381895

URL: http://svn.apache.org/viewvc?rev=1381895&view=rev
Log:
ZOOKEEPER-1380. zkperl: _zk_release_watch doesn't remove items properly from the watch list.
(Botond Hejj via mahadev)

Modified:
    zookeeper/branches/branch-3.4/CHANGES.txt
    zookeeper/branches/branch-3.4/src/contrib/zkperl/ZooKeeper.xs

Modified: zookeeper/branches/branch-3.4/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/branches/branch-3.4/CHANGES.txt?rev=1381895&r1=1381894&r2=1381895&view=diff
==============================================================================
--- zookeeper/branches/branch-3.4/CHANGES.txt (original)
+++ zookeeper/branches/branch-3.4/CHANGES.txt Fri Sep  7 06:13:38 2012
@@ -102,6 +102,9 @@ BUGFIXES:
   ZOOKEEPER-1105 c client zookeeper_close not send CLOSE_OP request to server
   (lincoln.lee via michim)
 
+  ZOOKEEPER-1380. zkperl: _zk_release_watch doesn't remove items properly from
+  the watch list. (Botond Hejj via mahadev)
+
 IMPROVEMENTS:
 
   ZOOKEEPER-1389. it would be nice if start-foreground used exec $JAVA

Modified: zookeeper/branches/branch-3.4/src/contrib/zkperl/ZooKeeper.xs
URL: http://svn.apache.org/viewvc/zookeeper/branches/branch-3.4/src/contrib/zkperl/ZooKeeper.xs?rev=1381895&r1=1381894&r2=1381895&view=diff
==============================================================================
--- zookeeper/branches/branch-3.4/src/contrib/zkperl/ZooKeeper.xs (original)
+++ zookeeper/branches/branch-3.4/src/contrib/zkperl/ZooKeeper.xs Fri Sep  7 06:13:38 2012
@@ -251,12 +251,12 @@ static void _zk_release_watch(pTHX_ zk_w
     if (list) {
         if (watch->prev) {
             watch->prev->next = watch->next;
-            watch->prev = NULL;
         }
         if (watch->next) {
             watch->next->prev = watch->prev;
-            watch->next = NULL;
         }
+        watch->prev = NULL;
+        watch->next = NULL;
     }
 
     if (--watch->ref_count == 0) {



Mime
View raw message