zookeeper-bookkeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sijie Guo (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BOOKKEEPER-184) CompactionTest failing on Jenkins
Date Tue, 13 Mar 2012 11:57:38 GMT

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228342#comment-13228342
] 

Sijie Guo commented on BOOKKEEPER-184:
--------------------------------------

the disabling of compaction did work before this change, which use #restartBookies()

{code}
// before restartBookies
2012-03-13 19:43:05,553 - INFO  - [main:GarbageCollectorThread@169] - Minor Compaction : enabled=true,
threshold=0.10000000149011612, interval=2000
2012-03-13 19:43:05,553 - INFO  - [main:GarbageCollectorThread@171] - Major Compaction : enabled=true,
threshold=0.5, interval=4000

// after restartBookies
2012-03-13 19:43:35,123 - INFO  - [main:GarbageCollectorThread@169] - Minor Compaction : enabled=false,
threshold=0.0, interval=2000
2012-03-13 19:43:35,123 - INFO  - [main:GarbageCollectorThread@171] - Major Compaction : enabled=false,
threshold=0.0, interval=4000
{code}

because ServerConfiguration is a CompositeConfiguration. A CompositeConfiguration object contains
a list of other configuration objects. When properties are accessed from a composite configuration
the object takes the passed in property key and iterates over the list of the contained configurations.
So when we changed baseConf, the changes would be took placed thru CompositeConfiguration.

This change use #restartBookies(baseConf), which just make code more clearly. it is same as
#restartBookies()


                
> CompactionTest failing on Jenkins
> ---------------------------------
>
>                 Key: BOOKKEEPER-184
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-184
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-184.diff
>
>
> the compaction test hanging on Jenkins. 
> Ivan did some investigation on this issue, and found that it wasn't hanging, it was just
taking a really long time. He suggested that it is because it does a lot of I/O, theres a
couple of ways we could reduce this.
> 1. Only create 1 bookie
> 2. Not inherit from BaseTestCase
> 3. Reduce the number of entries

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message