From dev-return-934-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Fri Jun 14 01:55:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E0BF118064E for ; Fri, 14 Jun 2019 03:54:59 +0200 (CEST) Received: (qmail 64045 invoked by uid 500); 14 Jun 2019 01:54:59 -0000 Mailing-List: contact dev-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list dev@zipkin.apache.org Received: (qmail 64034 invoked by uid 99); 14 Jun 2019 01:54:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jun 2019 01:54:59 +0000 From: GitBox To: dev@zipkin.apache.org Subject: [GitHub] [incubator-zipkin-brave] maxb3k commented on issue #842: Setting an existing uuid as a traceId Message-ID: <156047729899.29261.14347851968476338593.gitbox@gitbox.apache.org> Date: Fri, 14 Jun 2019 01:54:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit maxb3k commented on issue #842: Setting an existing uuid as a traceId URL: https://github.com/apache/incubator-zipkin-brave/issues/842#issuecomment-501938996 Thanks for the quick responding! I feel like i'm missing sleuth design considerations. Can you please point it out somewhere? Ideally it would be like a customization subsection in documentation of what we don't allow you to customize and why. I came to sleuth because of all the spring instrumentations. But i wanted to use UUID as a correlationId and to have customizable header names. And i see how it can be done but it looks more like hacking not customizing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org For additional commands, e-mail: dev-help@zipkin.apache.org