From dev-return-910-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Wed Jun 12 11:22:34 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1EB58180789 for ; Wed, 12 Jun 2019 13:22:34 +0200 (CEST) Received: (qmail 732 invoked by uid 500); 12 Jun 2019 11:22:10 -0000 Mailing-List: contact dev-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list dev@zipkin.apache.org Received: (qmail 702 invoked by uid 99); 12 Jun 2019 11:22:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2019 11:22:10 +0000 From: GitBox To: dev@zipkin.apache.org Subject: [GitHub] [incubator-zipkin-brave] adriancole commented on issue #924: Makes Tracer.currentSpanCustomizer() lazy Message-ID: <156033852915.30554.8900933817005659256.gitbox@gitbox.apache.org> Date: Wed, 12 Jun 2019 11:22:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #924: Makes Tracer.currentSpanCustomizer() lazy URL: https://github.com/apache/incubator-zipkin-brave/pull/924#issuecomment-501230589 ps the use cases for calling tracer.currentSpan and not using the result are one of.. * checking null from `tracer.currentSpan()` as a signal for "is current" * defensively doing some parsing based on whether or not `Span.isNoop()` just guessing.. I think usually it would be a bug to call `Tracer.currentSpan()` and drop the result. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org For additional commands, e-mail: dev-help@zipkin.apache.org