From dev-return-905-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Wed Jun 12 09:34:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E48C18061A for ; Wed, 12 Jun 2019 11:34:55 +0200 (CEST) Received: (qmail 94376 invoked by uid 500); 12 Jun 2019 09:34:54 -0000 Mailing-List: contact dev-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list dev@zipkin.apache.org Received: (qmail 94363 invoked by uid 99); 12 Jun 2019 09:34:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2019 09:34:54 +0000 From: GitBox To: dev@zipkin.apache.org Subject: [GitHub] [incubator-zipkin-brave] adriancole commented on issue #920: brave.flush annotation reported for already finished span Message-ID: <156033209472.29536.3773231734924318372.gitbox@gitbox.apache.org> Date: Wed, 12 Jun 2019 09:34:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #920: brave.flush annotation reported for already finished span URL: https://github.com/apache/incubator-zipkin-brave/issues/920#issuecomment-501196663 spent some time on flight and think the best first start is making an unused span from tracer.currentspan cheaper. fixing this will sort out the flush problem too ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org For additional commands, e-mail: dev-help@zipkin.apache.org