From dev-return-841-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Mon Jun 3 09:05:19 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 271CF18062F for ; Mon, 3 Jun 2019 11:05:19 +0200 (CEST) Received: (qmail 10111 invoked by uid 500); 3 Jun 2019 09:05:18 -0000 Mailing-List: contact dev-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list dev@zipkin.apache.org Received: (qmail 10100 invoked by uid 99); 3 Jun 2019 09:05:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jun 2019 09:05:18 +0000 From: GitBox To: dev@zipkin.apache.org Subject: [GitHub] [incubator-zipkin-brave] adriancole commented on issue #919: Span not reporting http status 200 ok for successful api request Message-ID: <155955271853.8425.11752333270106279634.gitbox@gitbox.apache.org> Date: Mon, 03 Jun 2019 09:05:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #919: Span not reporting http status 200 ok for successful api request URL: https://github.com/apache/incubator-zipkin-brave/issues/919#issuecomment-498175069 hi! incidentally you must be using an older version of brave as that code has changed. Can you verify you still have a concern? https://github.com/apache/incubator-zipkin-brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpParser.java#L160 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org For additional commands, e-mail: dev-help@zipkin.apache.org