zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on a change in pull request #896: feat: use p6spy's log filtering settings when tracing
Date Mon, 17 Jun 2019 00:43:16 GMT
adriancole commented on a change in pull request #896: feat: use p6spy's log filtering settings
when tracing
URL: https://github.com/apache/incubator-zipkin-brave/pull/896#discussion_r294109039
 
 

 ##########
 File path: instrumentation/p6spy/README.md
 ##########
 @@ -42,3 +42,10 @@ jdbc:mysql://127.0.0.1:3306/mydatabase?zipkinServiceName=myServiceName
 This will override the `remoteServiceName` set in `spy.properties`.
 
 The current tracing component is used at runtime. Until you have instantiated `brave.Tracing`,
no traces will appear.
+
+### Log filtering
+
 
 Review comment:
   ```suggestion
   
   By default, all statements are recorded as client spans. You may wish to exclude statements
like `set session` from tracing. This library reuses p6spy's log filtering for this purpose.
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message