zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on issue #927: Fixes assertion by making equals the same between lazy and real span
Date Sat, 15 Jun 2019 13:40:06 GMT
adriancole commented on issue #927: Fixes assertion by making equals the same between lazy
and real span
URL: https://github.com/apache/incubator-zipkin-brave/pull/927#issuecomment-502367861
 
 
   eventhough this only hurt when assertions are on, I will cut a release as it is pretty
dire to always fail when assertions are on (ex unit tests that use brave can bork)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message