zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] lambcode commented on issue #920: brave.flush annotation reported for already finished span
Date Wed, 12 Jun 2019 16:46:59 GMT
lambcode commented on issue #920: brave.flush annotation reported for already finished span
URL: https://github.com/apache/incubator-zipkin-brave/issues/920#issuecomment-501359787
 
 
   It does look like CurrentTraceContext.get() would work for our use case. We were getting
the current span just for the current trace id (for logging purposes). That said, it'll still
be nice to have this resolved because there's no way to prevent others from making this same
mistake.
   
   PS I like the direction you're going in #924 better than my original proposal :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message