zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on issue #924: Makes Tracer.currentSpanCustomizer() lazy
Date Wed, 12 Jun 2019 11:22:09 GMT
adriancole commented on issue #924:  Makes Tracer.currentSpanCustomizer() lazy 
URL: https://github.com/apache/incubator-zipkin-brave/pull/924#issuecomment-501230589
 
 
   ps the use cases for calling tracer.currentSpan and not using the result are one of..
   * checking null from `tracer.currentSpan()` as a signal for "is current"
   * defensively doing some parsing based on whether or not `Span.isNoop()`
   
   just guessing.. I think usually it would be a bug to call `Tracer.currentSpan()` and drop
the result.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message