zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole opened a new pull request #924: Makes Tracer.currentSpanCustomizer() lazy
Date Wed, 12 Jun 2019 11:13:20 GMT
adriancole opened a new pull request #924:  Makes Tracer.currentSpanCustomizer() lazy 
URL: https://github.com/apache/incubator-zipkin-brave/pull/924
 
 
   @lambcode noticed that calling `Tracer.currentSpan()` without using the
   result can lead to orphaned spans. The simplest way to prevent this is
   to defer overhead until data is added with the result.
   
   Fixes #920
   
   Added benchmarks..
   
   before
   
   ```
   TracerBenchmarks.currentSpan:currentSpan·p0.999                          sample      
      8.560             us/op
   TracerBenchmarks.currentSpan:·gc.alloc.rate.norm                         sample      15
   88.012 ±   0.005    B/op
   TracerBenchmarks.currentSpan_tag:currentSpan_tag·p0.999                  sample      
     20.256             us/op
   TracerBenchmarks.currentSpan_tag:·gc.alloc.rate.norm                     sample      15
   88.065 ±   0.004    B/op
   TracerBenchmarks.currentSpan_unsampled:currentSpan_unsampled·p0.999      sample      
      4.995             us/op
   TracerBenchmarks.currentSpan_unsampled:·gc.alloc.rate.norm               sample      15
   24.005 ±   0.001    B/op
   ```
   
   after
   
   ```
   TracerBenchmarks.currentSpan:currentSpan·p0.999                          sample      
       7.974             us/op
   TracerBenchmarks.currentSpan:·gc.alloc.rate.norm                         sample      15
    24.015 ±   0.008    B/op
   TracerBenchmarks.currentSpan_tag:currentSpan_tag·p0.999                  sample      
      10.192             us/op
   TracerBenchmarks.currentSpan_tag:·gc.alloc.rate.norm                     sample      15
    72.050 ±  12.511    B/op
   TracerBenchmarks.currentSpan_unsampled:currentSpan_unsampled·p0.999      sample      
       4.198             us/op
   TracerBenchmarks.currentSpan_unsampled:·gc.alloc.rate.norm               sample      15
    24.009 ±   0.007    B/op
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message