zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on issue #920: brave.flush annotation reported for already finished span
Date Wed, 12 Jun 2019 06:04:35 GMT
adriancole commented on issue #920: brave.flush annotation reported for already finished span
URL: https://github.com/apache/incubator-zipkin-brave/issues/920#issuecomment-501133222
 
 
   here's some feedback about your proposal specific to keeping a dead instance to prevent
resurrecting spans.
   
   To carry a tombstone state, we would need to either add a field to RealKey, refactor its
internals or make a separate mapping. any of these would add overhead unless you are thinking
something clever. For example, there is a size added for every field in an object. The differences
can be seen via JMH with a profiling plugin enabled.. some of our benchmarks have this plugin
enabled. You can also eyeball via approaches like [this](https://www.baeldung.com/java-size-of-object)
   
   Anyway, we should be interested in finding a way besides adding tracking fields. But before
all that, isolating the concern itself. Thanks for the start on this and the patience!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message