From dev-return-780-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Mon May 27 15:08:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E1A9D180638 for ; Mon, 27 May 2019 17:08:34 +0200 (CEST) Received: (qmail 53527 invoked by uid 500); 27 May 2019 15:08:34 -0000 Mailing-List: contact dev-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list dev@zipkin.apache.org Received: (qmail 53515 invoked by uid 99); 27 May 2019 15:08:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 May 2019 15:08:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 60571C351A for ; Mon, 27 May 2019 15:08:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.3 X-Spam-Level: ** X-Spam-Status: No, score=2.3 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id T9woId4vVzHu for ; Mon, 27 May 2019 15:08:31 +0000 (UTC) Received: from mail-yw1-f51.google.com (mail-yw1-f51.google.com [209.85.161.51]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 13BFF612E4 for ; Mon, 27 May 2019 15:08:31 +0000 (UTC) Received: by mail-yw1-f51.google.com with SMTP id x144so2612372ywd.13 for ; Mon, 27 May 2019 08:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=9lsGB+WtEgGgs9H1Y2fWJBGF90OWFqbMTDGve9GLTvA=; b=EACiFU/jc1LK8Xt3J0mfV/Pe487eA8OaLsdWcsENPwO8LGfhdHS+THD00HW0id9ISC KNeSLl8rmfP7HlKf8w71lU4a5j+MlcrIhbLDXfcZuJqjr6PvELhVBokNCyaJUWGfgm7b 8MTWw/v06ddRL1izbZNFu2NZoz9avlQzyvOS2hAlFFnec3TvPIaxGUUOqokIhA4MCRCA PfEP/4z5LZeU/sjDILcyRicCeVvHp0M+YxGT8vA2AnkgMdHLjdd17qd5ta7DHcuxCvX3 J1IDZQgyHW44uHmEnRlK5yxm18p0AOcmqtKh5AjDsoWuyjEMI24pf+4EqXwU+Wi5HUL2 lM2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=9lsGB+WtEgGgs9H1Y2fWJBGF90OWFqbMTDGve9GLTvA=; b=CQASfp0xs966riwBnNlV6X750hNuPQVq/QDqMOIzN6eod9ZGswbQVN7/lsKPJt0pic O6ZSuq4dTlKJpkNJMXgHVmHl6pCNG4vfRh4Z6qFD3ouwLsAEsB7wValNFbxPTM+qQqW2 dUUbfquWQKTu4noUwcb4PJlFjTYak/v/eTBqkWWv+sHyGJV3Rrr/J0yQmt/9GAYO4C5d qhB8EBorLOFbAceROu6c4fPfqrEB6QbuiNue2U7LU1p0b/sKxUpmvY7WGnbzs4Cxs3ql nDGM7QNXpZUZfmoxb2awVuNNG7jJ/MDlfKd84ndGUTaycaPsmDtvvxoKfY8ci1K+Bfuk dWBg== X-Gm-Message-State: APjAAAUAqbd461jY+jVhZPkCgkqBI/S/icPGLftDfSn5t8Emun+gup00 a0gd9thZYE2kT6hu6K19nN31ssK9ZQPy+X+IEGSOEfL0RZ4= X-Google-Smtp-Source: APXvYqwphsjnTLahsilSnDJJDKx3vSRH9b0Yoc8YNPHXcwOB+ohoyTZ6fC4sNxGeRJK5gy/AT+up+sP0ZjXqrXXfLNM= X-Received: by 2002:a0d:d515:: with SMTP id x21mr5941406ywd.160.1558969703333; Mon, 27 May 2019 08:08:23 -0700 (PDT) MIME-Version: 1.0 References: <97457580-cbaf-0862-0e03-5f5fbcd512b8@gmail.com> <1525825663.20190520222744@gmail.com> <136785008.20190521070811@gmail.com> In-Reply-To: <136785008.20190521070811@gmail.com> From: Tommy Ludwig Date: Tue, 28 May 2019 00:08:12 +0900 Message-ID: Subject: Re: [VOTE] Release Apache Zipkin Reporter (incubating) version 2.8.3 To: dev@zipkin.apache.org Content-Type: multipart/alternative; boundary="00000000000062056e0589dfeb13" --00000000000062056e0589dfeb13 Content-Type: text/plain; charset="UTF-8" +1 I checked: [PASS] Source archive has expected name [PASS] SHA512 checksum is correct [PASS] Provided GPG key is in KEYS file [PASS] GPG signature is valid, made with the provided key [PASS] Base dir in archive has expected name [PASS] Git tree at provided revision matches source archive [PASS] DISCLAIMER and NOTICE look good [PASS] LICENSE looks good [PASS] No binary files in the release [PASS] Source builds and tests pass (`mvn test`) On Tue, May 21, 2019 at 8:08 PM Andriy Redko wrote: > Sure, sounds good Adrian! Thank you! > > Best Regards, > Andriy Redko > > > Tuesday, May 21, 2019, 2:35:00 AM, you wrote: > > > Thanks, Andriy. > > We have been working with the understanding that we get "mvn test" to > execute as many projects include integration tests that have some > workstation sensitivity, but are not required to execute for the project to > pass tests (unit tests). For example, we have no plans to be a docker > support organization either and some projects use docker for heavy tests. > > Instead of deleting these integration tests or moving them to a separate > repository, solely to pass the source verification.. we classify them under > integration tests which means they are invoked when people use the "verify" > goal instead of "test" which some actually dont know about, but heh was > precisely what you used. In other words we explicitly had these as ITxx to > prevent needing to support exactly what you asked about. > > Moreover, we have had this exact discussion before in zipkin brave karaf, > probably you maybe forgot that. > > Is there something in our README that is telling someone to use verify > implicitly? if so we should add skipITs to that in the next release. > > If not, I would suggest we don't repeat the conversation about integration > tests on every package we release as there will be nothing different > between these conversations and having them might introduce FUD when we go > for IPMC or yet another thing to talk about, for every repo, when what is > being discussed is not required for someone to build and test the software > and also formerly discussed and came to conclusion. > > make sense? > > -A > > On Tue, May 21, 2019, 4:27 AM Andriy Redko wrote: > > +1, binding > > SHA512 checksum matches > Naming conventions are followed > GPG signature verified > LICENSE, DISCLAIMER and NOTICE file exist and look good > No binary files in the source archive > The project builds successfuly, the tests are passing (but not integration > ones, see please below) > > When running 'mvn clean verify' on Windows box, I have got consistent > 'zipkin2.reporter.kafka08.ITKafkaSender' > failure: > > [ERROR] Process Exit Code: 0 > [ERROR] Crashed tests: > [ERROR] zipkin2.reporter.kafka08.ITKafkaSender > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:511) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:458) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:299) > [ERROR] at > org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:247) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1161) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1002) > [ERROR] at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:848) > [ERROR] at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) > [ERROR] at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) > [ERROR] at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56) > [ERROR] at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) > [ERROR] at > org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305) > [ERROR] at > org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) > [ERROR] at > org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) > [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:956) > > It seems to be known 'kafka-junit' issue [0] and in my opinion, this is > not a blocker for release. > > [0] https://github.com/charithe/kafka-junit/issues/25 > > > Best Regards, > Andriy Redko > > > JQ> Hello Zipkin Community, > > JQ> This is a call for the vote to release Apache Zipkin Reporter > (incubating) version > JQ> 2.8.3. > > JQ> The release candidates: > JQ> > https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-reporter-java/2.8.3/ > > JQ> Git tag for the release: > JQ> https://github.com/apache/incubator-zipkin-reporter-java/tree/v2.8.3 > > JQ> Hash for the release tag: e6791fcd4081fb58cd9d5f7e3eac42fbbb034d51 > > JQ> Release Notes: > JQ> > https://github.com/apache/incubator-zipkin-reporter-java/releases/tag/v2.8.3 > > JQ> The artifacts have been signed with Key: 50D90C2C, which can be found > in > JQ> the keys file: > > JQ> https://www.apache.org/dist/incubator/zipkin/KEYS > > JQ> Verification Hints: > JQ> For your convenience, the below includes a detailed how-to on > verifying a > JQ> source release. Please note that this document is a > JQ> work-in-progress > JQ> > https://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release > > JQ> The vote will be open for at least 72 hours or until the necessary > number > JQ> of votes are reached. > > JQ> Please vote accordingly: > > JQ> [ ] +1 approve > JQ> [ ] +0 no opinion > JQ> [ ] -1 disapprove with the reason > > JQ> Thanks, > JQ> The Apache Zipkin (Incubating) Team > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org > For additional commands, e-mail: dev-help@zipkin.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org > For additional commands, e-mail: dev-help@zipkin.apache.org > > --00000000000062056e0589dfeb13--