From dev-return-774-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Sun May 26 00:35:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0D83118065D for ; Sun, 26 May 2019 02:35:54 +0200 (CEST) Received: (qmail 76063 invoked by uid 500); 26 May 2019 00:35:54 -0000 Mailing-List: contact dev-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list dev@zipkin.apache.org Received: (qmail 76052 invoked by uid 99); 26 May 2019 00:35:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 May 2019 00:35:54 +0000 From: GitBox To: dev@zipkin.apache.org Subject: [GitHub] [incubator-zipkin-brave] jeqo commented on a change in pull request #904: Messaging adapter Message-ID: <155883095415.2001.16098401183820851967.gitbox@gitbox.apache.org> Date: Sun, 26 May 2019 00:35:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jeqo commented on a change in pull request #904: Messaging adapter URL: https://github.com/apache/incubator-zipkin-brave/pull/904#discussion_r287578459 ########## File path: instrumentation/messaging/src/main/java/brave/messaging/MessagingTracing.java ########## @@ -0,0 +1,50 @@ +package brave.messaging; + +import brave.Tracing; + +public class MessagingTracing { + + public static MessagingTracing create(Tracing tracing) { + return newBuilder(tracing).build(); + } + + public static MessagingTracing.Builder newBuilder(Tracing tracing) { + return new MessagingTracing.Builder(tracing); + } + + final Tracing tracing; + final MessagingParser parser; + + MessagingTracing(Builder builder) { + this.tracing = builder.tracing; + this.parser = builder.parser; + } + + public Tracing tracing() { + return tracing; + } + + public MessagingParser parser() { Review comment: Fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org For additional commands, e-mail: dev-help@zipkin.apache.org