From dev-return-691-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Mon May 13 00:14:22 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B203118062F for ; Mon, 13 May 2019 02:14:21 +0200 (CEST) Received: (qmail 12963 invoked by uid 500); 13 May 2019 00:14:21 -0000 Mailing-List: contact dev-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list dev@zipkin.apache.org Received: (qmail 12950 invoked by uid 99); 13 May 2019 00:14:21 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 May 2019 00:14:21 +0000 From: GitBox To: dev@zipkin.apache.org Subject: [GitHub] [incubator-zipkin-brave] adriancole commented on issue #904: Messaging adapter Message-ID: <155770645680.2481.13808392017761869984.gitbox@gitbox.apache.org> Date: Mon, 13 May 2019 00:14:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #904: Messaging adapter URL: https://github.com/apache/incubator-zipkin-brave/pull/904#issuecomment-491641030 flush wont set a end timestamp which we need eventually. flushing before finish will make reporting chatty and analysis more heavy as multiple docs per span On Fri, May 10, 2019, 1:09 AM Brian Devins-Suresh wrote: > *@devinsba* commented on this pull request. > ------------------------------ > > In > instrumentation/messaging/src/main/java/brave/messaging/MessagingProducerHandler.java > > : > > > + Span span; > + if (maybeParent == null) { > + span = tracer.nextSpan(parser.extractContextAndClearMessage(adapter, extractor, message)); > + } else { > + // As JMS is sensitive about write access to headers, we defensively clear even if it seems > + // upstream would have cleared (because there is a span in scope!). > + span = tracer.newChild(maybeParent); > + adapter.clearPropagation(message); > + } > + > + if (!span.isNoop()) { > + span.kind(Span.Kind.PRODUCER).name("send"); > + parser.message(adapter, message, span); > + String remoteServiceName = adapter.remoteServiceName(message); > + if (remoteServiceName != null) span.remoteServiceName(remoteServiceName); > + span.start(); > > Elsewhere we've done: span.start().finish(); though I'm not sure I like > that pattern a ton, since this will end up flushed anyway, maybe we should > flush explictly > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org For additional commands, e-mail: dev-help@zipkin.apache.org