zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on issue #904: Messaging adapter
Date Wed, 29 May 2019 08:04:18 GMT
adriancole commented on issue #904: Messaging adapter
URL: https://github.com/apache/incubator-zipkin-brave/pull/904#issuecomment-496830363
 
 
   I think we need to add a copy of sqs instrumentation perhaps in the src/test tree in order
to verify the design and then remove it later. rule of 3 of abstraction.. and we know there
were some kinks. if it is vendored into the src/test tree we can easily collaborate on it
and change the design. @llinder if you have some time to move your wip here much oblidged

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message