zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] jeqo commented on issue #904: Messaging adapter
Date Sun, 26 May 2019 22:39:52 GMT
jeqo commented on issue #904: Messaging adapter
URL: https://github.com/apache/incubator-zipkin-brave/pull/904#issuecomment-496037141
 
 
   @llinder I'm wondering if the comments on `cleanPropagation` still holds after considering
[this idea from pow-wow](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=113709067):
   
   > One idea is that we use only idempotent header formats. meaning that there are no
headers that need to be read before written. ex lower b3 single format
   
   My understanding of idempotency in this case is that we "don't care" about cleaning context
carrier, but just override value if already exist. 
   
   If this is correct, then we should not be a `clearPropagation`; or at least not as part
of the Parser API. 
   For instance, I know that for JMS we actually *need* to clear message properties before
updating value, otherwise it fails with read-only properties. In this case we would have to
clear on injector setter, I think.
   
   I'd like your feedback on:
   - Does this interpretation of idempotency make sense to everyone?
   - Should we constraint to B3 single header format moving forward?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message