zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on a change in pull request #904: Messaging adapter
Date Mon, 20 May 2019 13:33:45 GMT
adriancole commented on a change in pull request #904: Messaging adapter
URL: https://github.com/apache/incubator-zipkin-brave/pull/904#discussion_r285594418
 
 

 ##########
 File path: instrumentation/messaging/src/main/java/brave/messaging/MessageProducerAdapter.java
 ##########
 @@ -0,0 +1,20 @@
+package brave.messaging;
+
+public interface MessageProducerAdapter<Msg> extends MessageAdapter<Msg> {
+  /**
+   * Messaging operation semantics, e.g. pull, push, send, receive, etc.
+   */
+  String operation(Msg message);
+
+  /**
+   * Message identifier, e.g. kafka record key, jms message correlation id.
+   */
+  String identifier(Msg message);
+
+  /**
+   * Removes propagation context from Message context carrier.
+   */
+  void clearPropagation(Msg message);
 
 Review comment:
   good and even better with a comment reminding that

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message