zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-dependencies] adriancole commented on a change in pull request #139: Corrects fuzz in build in preparation for ASF release
Date Sat, 18 May 2019 09:31:39 GMT
adriancole commented on a change in pull request #139: Corrects fuzz in build in preparation
for ASF release
URL: https://github.com/apache/incubator-zipkin-dependencies/pull/139#discussion_r285335776
 
 

 ##########
 File path: README.md
 ##########
 @@ -126,7 +126,7 @@ To build the job from source and run against a local cassandra, in Spark's
stand
 
 ```bash
 # Build the spark jobs
-$ ./mvnw -DskipTests clean install
+$ mvn -DskipTests clean install
 
 Review comment:
   we don't publish the maven wrapper in our source dist. this README ends up in the source
dist. we have gotten nitpicked about references to mvnw in previous releases. this tries to
avoid that nit picking

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message