zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-dependencies] adriancole commented on a change in pull request #139: Corrects fuzz in build in preparation for ASF release
Date Sat, 18 May 2019 09:31:39 GMT
adriancole commented on a change in pull request #139: Corrects fuzz in build in preparation
for ASF release
URL: https://github.com/apache/incubator-zipkin-dependencies/pull/139#discussion_r285335790
 
 

 ##########
 File path: cassandra3/src/main/java/zipkin2/dependencies/cassandra3/CassandraDependenciesJob.java
 ##########
 @@ -125,8 +125,7 @@ public Builder localDc(@Nullable String localDc) {
       return this;
     }
 
-    /** @see {@code StorageComponent.Builder#strictTraceId(boolean)} */
-    public Builder strictTraceId(boolean strictTraceId) {
+    Builder strictTraceId(boolean strictTraceId) {
 
 Review comment:
   only used in tests.. the code ref (and even the see ref) were causing javadoc problems.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message