zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] jeqo commented on issue #902: kafka-streams integration-tests
Date Thu, 16 May 2019 11:23:48 GMT
jeqo commented on issue #902: kafka-streams integration-tests
URL: https://github.com/apache/incubator-zipkin-brave/issues/902#issuecomment-493027950
 
 
   Sorry for the late reply @jorgheymans 
   Renaming to `createProducer` will probably be enough.
   As by testing `nextSpan`, `https://github.com/apache/incubator-zipkin-brave/blob/3f84fa27e8/instrumentation/kafka-streams/src/test/java/brave/kafka/streams/KafkaStreamsTracingTest.java`
might be already covering this API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message