zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on issue #904: Messaging adapter
Date Mon, 13 May 2019 00:14:16 GMT
adriancole commented on issue #904: Messaging adapter
URL: https://github.com/apache/incubator-zipkin-brave/pull/904#issuecomment-491641030
 
 
   flush wont set a end timestamp which we need eventually. flushing before
   finish will make reporting chatty and analysis more heavy as multiple docs
   per span
   
   On Fri, May 10, 2019, 1:09 AM Brian Devins-Suresh <notifications@github.com>
   wrote:
   
   > *@devinsba* commented on this pull request.
   > ------------------------------
   >
   > In
   > instrumentation/messaging/src/main/java/brave/messaging/MessagingProducerHandler.java
   > <https://github.com/apache/incubator-zipkin-brave/pull/904#discussion_r282579930>
   > :
   >
   > > +    Span span;
   > +    if (maybeParent == null) {
   > +      span = tracer.nextSpan(parser.extractContextAndClearMessage(adapter, extractor,
message));
   > +    } else {
   > +      // As JMS is sensitive about write access to headers, we  defensively clear
even if it seems
   > +      // upstream would have cleared (because there is a span in scope!).
   > +      span = tracer.newChild(maybeParent);
   > +      adapter.clearPropagation(message);
   > +    }
   > +
   > +    if (!span.isNoop()) {
   > +      span.kind(Span.Kind.PRODUCER).name("send");
   > +      parser.message(adapter, message, span);
   > +      String remoteServiceName = adapter.remoteServiceName(message);
   > +      if (remoteServiceName != null) span.remoteServiceName(remoteServiceName);
   > +      span.start();
   >
   > Elsewhere we've done: span.start().finish(); though I'm not sure I like
   > that pattern a ton, since this will end up flushed anyway, maybe we should
   > flush explictly
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin-brave/pull/904#pullrequestreview-235713331>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAAPVVZGL3DRIHLBDIYATQ3PURLFFANCNFSM4HLUBZKQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message