zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on issue #908: Fixes some edge cases around sampler resetting
Date Sat, 11 May 2019 14:47:55 GMT
adriancole commented on issue #908: Fixes some edge cases around sampler resetting
URL: https://github.com/apache/incubator-zipkin-brave/pull/908#issuecomment-491516989
 
 
   I used https://github.com/adriancole/zipkin-voltdb to integration test this and sent 4
bursts of 10 seconds of 3K+ requests/second. Using a throttled rate of 20/second it ended
up quite close to correct (778 instead of 800). Note most of the gap seems warmup related
and I don't completely understand that. Ex the last burst had 196 traces (20/second * 10 seconds)
so quite close.
   
   ![Screen Shot 2019-05-11 at 10 42 36 PM](https://user-images.githubusercontent.com/64215/57571269-4d964980-743e-11e9-9717-745a1cf96c7b.png)
   
   (note: this is based on export/tail sampling.. we should probably bundle this in zipkin
lib so we don't have to copy/paste for collectors to use it)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message