zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] anuraaga commented on issue #907: Reuse buffer when converting long to hex.
Date Sat, 11 May 2019 09:00:23 GMT
anuraaga commented on issue #907: Reuse buffer when converting long to hex.
URL: https://github.com/apache/incubator-zipkin-brave/pull/907#issuecomment-491493622
 
 
   Ah - looks like tests here mock out `Platform`. As this isn't really platform-dependent,
I'm thinking of a separate class `RecycledBuffers` to avoid changing a lot. Does that make
sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message