zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on issue #905: reduce amount of array allocation
Date Sat, 11 May 2019 07:42:58 GMT
adriancole commented on issue #905: reduce amount of array allocation
URL: https://github.com/apache/incubator-zipkin-brave/issues/905#issuecomment-491488715
 
 
   Carrying over from the other issue. `HexCodec.toLowerHex` is only used by `TraceContext`,
so could probably be moved there. A buffer, possibly named `Platform.idBuffer` could be shared
between `B3SingleFormat` and `TraceContext`.
   
   `TagContextBinaryMarshaller.readAsciiString` is used in gRPC, but defined in census. It
looks like that is variable length so not sure how well a shared buffer would be or not https://github.com/census-instrumentation/opencensus-java/blob/1023986bd56612cb0f0631214d8160679c01a108/impl_core/src/main/java/io/opencensus/implcore/tags/propagation/BinarySerializationUtils.java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message