zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole opened a new issue #905: reduce amount of array allocation
Date Sat, 11 May 2019 07:12:04 GMT
adriancole opened a new issue #905: reduce amount of array allocation
URL: https://github.com/apache/incubator-zipkin-brave/issues/905
 
 
   in `B3SingleFormat`, we do something like https://github.com/apache/incubator-zipkin/pull/2582
to reduce array allocations. However, we don't at `TagContextBinaryMarshaller.readAsciiString`,
`TagContextBinaryMarshaller.readAsciiString` and `HexCodec.toLowerHex`.
   
   
   Note: we don't at `TraceContext.toString` and `TraceIdContext.toString` either, but these
I don't think are called in the critical path of anything.
   
   cc @anuraaga

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message