zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on a change in pull request #904: Messaging adapter
Date Thu, 09 May 2019 00:16:34 GMT
adriancole commented on a change in pull request #904: Messaging adapter
URL: https://github.com/apache/incubator-zipkin-brave/pull/904#discussion_r282297418
 
 

 ##########
 File path: instrumentation/kafka-clients/src/test/java/brave/kafka/clients/HeadersSetterTest.java
 ##########
 @@ -22,7 +21,7 @@
   }
 
   @Override protected Propagation.Setter<Headers, String> setter() {
-    return SETTER;
+    return null;//FIXME SETTER;
 
 Review comment:
   ```suggestion
       throw new AssertionError("FIXME SETTER");
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message