zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-brave] adriancole commented on a change in pull request #904: Messaging adapter
Date Thu, 09 May 2019 00:16:34 GMT
adriancole commented on a change in pull request #904: Messaging adapter
URL: https://github.com/apache/incubator-zipkin-brave/pull/904#discussion_r282296919
 
 

 ##########
 File path: instrumentation/messaging/src/main/java/brave/messaging/MessagingTracing.java
 ##########
 @@ -0,0 +1,50 @@
+package brave.messaging;
+
+import brave.Tracing;
+
+public class MessagingTracing {
+
+  public static MessagingTracing create(Tracing tracing) {
+    return newBuilder(tracing).build();
+  }
+
+  public static MessagingTracing.Builder newBuilder(Tracing tracing) {
+    return new MessagingTracing.Builder(tracing);
+  }
+
+  final Tracing tracing;
+  final MessagingParser parser;
+
+  MessagingTracing(Builder builder) {
+    this.tracing = builder.tracing;
+    this.parser = builder.parser;
+  }
+
+  public Tracing tracing() {
+    return tracing;
+  }
+
+  public MessagingParser parser() {
 
 Review comment:
   probably will need a consumerParser and producerParser unless we think the exact same data
will be used in both places

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message