zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <adrian.f.c...@gmail.com>
Subject feedback needed on pull request about remote service name
Date Wed, 10 Apr 2019 00:00:55 GMT
Hi, all. This is referencing a non-ASF repo, but that's by accident.
We've had a request to move it for a week [1] and I can't sensibly
block technical discussions longer just because of jurisdiction. I'll
proceed to the point now :)

We have a long term issue with local and remote services being stuck
in the same api results. This causes UI auto-complete pollution and we
have code to sort this out. I offered to help spike this to allow lens
to take advantage of it. However, there are two points I really do
need other people to weigh in on.

* allow remoteServiceName query even when serviceName query is missing [2]
* review that copying the same pattern for span name indexing in
cassandra is the right choice [3]

I know all are flat out, but it would be great to land this for the
next version (ideally the ASF version if someone can migrate our
repos)

Best,
-A

[1] https://issues.apache.org/jira/browse/INFRA-16989?focusedCommentId=16807394&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16807394
[2] https://github.com/openzipkin/zipkin/issues/1794#issuecomment-481482792
[3] https://github.com/openzipkin/zipkin/pull/2484#pullrequestreview-224355781

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message