zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <adrian.f.c...@gmail.com>
Subject Re: [VOTE] Release Apache Zipkin API (incubating) version 0.2.1
Date Mon, 29 Apr 2019 00:32:37 GMT
+1

Note: our work-in-progress source verification tool isn't designed yet
for projects that have very different contents in the source dist from
the github repository. This is currently not a priority as neither do
we frequently update our IDL, but also it would be hard to special
case this.


Here's what I did:

$ docker run --rm -ti
abesto/openzipkin-contrib-apache-release-verification   --module
zipkin-api --version 0.2.1 --gpg-key 50D90C2C   --git-hash
f6e41b694f0083eb6212bf2986f589b2cf699f50 --repo dev
--zipname-template
'apache-{module}{dash_incubating}-{version}-source-release'
--github-reponame-template '{incubator_dash}{module}.git'

[PASS] GPG signature is valid, made with the provided key
[PASS] Base dir in archive has expected name
[FAIL] Git tree at provided revision matches source archive <<
manually verified and it is fine
/tmp/tmp0xka88vi/git/incubator-zipkin-api.git/javadoc is only in the
git checkout <- dummy file for maven
/tmp/tmp0xka88vi/git/incubator-zipkin-api.git/package.json is only in
the git checkout <- used in CI: checks the json api yaml for syntax
errors
/tmp/tmp0xka88vi/git/incubator-zipkin-api.git/pom.xml is only in the
git checkout <- different proto-only distribution
/tmp/tmp0xka88vi/git/incubator-zipkin-api.git/src is only in the git
checkout <- dummy source dir for maven
/tmp/tmp0xka88vi/git/incubator-zipkin-api.git/validate.js is only in
the git checkout <- used in CI: checks the json api yaml for syntax
errors
See above for a full output of diff.
[PASS] No .gitignore-d files in source archive
[PASS] DISCLAIMER and NOTICE look good
[PASS] LICENSE looks good
[PASS] No binary files in the release

After verifying that the files excluded aren't needed with the above
output, I verified the files we included were correct.

# from svn https://dist.apache.org/repos/dist/dev/incubator/zipkin
$ svn up
$ jar -tvf zipkin-api/0.2.1/apache-zipkin-api-incubating-0.2.1-source-release.zip
     0 Sat Apr 27 18:30:22 MYT 2019 zipkin-api-0.2.1/
     0 Sat Apr 27 18:30:22 MYT 2019 zipkin-api-0.2.1/thrift/
   553 Fri Apr 26 22:34:56 MYT 2019 zipkin-api-0.2.1/DISCLAIMER
 16262 Thu Apr 25 13:44:28 MYT 2019 zipkin-api-0.2.1/zipkin-api.yaml
<- v1 json IDL
   747 Fri Apr 26 22:34:56 MYT 2019 zipkin-api-0.2.1/README.md
 10147 Thu Apr 25 13:44:28 MYT 2019 zipkin-api-0.2.1/zipkin.proto <-
v2 protobuf IDL
 19730 Thu Apr 25 13:44:28 MYT 2019
zipkin-api-0.2.1/thrift/zipkinCore.thrift <- v1 thrift IDL
 11357 Thu Apr 25 13:44:28 MYT 2019 zipkin-api-0.2.1/LICENSE
  1474 Thu Apr 25 13:44:28 MYT 2019
zipkin-api-0.2.1/thrift/zipkinDependencies.thrift <- v1 thrift
dependency linking IDL
 20678 Thu Apr 25 13:44:28 MYT 2019 zipkin-api-0.2.1/zipkin2-api.yaml
<- v2 json IDL
   220 Thu Apr 25 13:44:28 MYT 2019 zipkin-api-0.2.1/NOTICE

all good

On Sun, Apr 28, 2019 at 5:01 PM Jorge Quilcate <quilcate.jorge@gmail.com> wrote:
>
> Hello Zipkin Community,
>
> This is a call for vote to release Apache Zipkin API (incubating)
> version 0.2.1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-api/0.2.1/
>
> Git tag for the release:
> https://github.com/apache/incubator-zipkin-api/tree/v0.2.1
>
> Hash for the release tag: f6e41b694f0083eb6212bf2986f589b2cf699f50
>
> Release Notes:
> https://github.com/apache/incubator-zipkin-api/releases/tag/v0.2.1
>
> The artifacts have been signed with Key : 50D90C2C, which can be found
> in the keys file:
> https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS
>
> Verification Hints:
> For your convenience, the below includes detailed how-to on verifying a
> source release. Please note that this document is a
> work-in-progresshttps://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Zipkin (Incubating) Team
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail: dev-help@zipkin.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message