zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <adrian.f.c...@gmail.com>
Subject Re: [VOTE] Release Apache Zipkin API (incubating) version 0.2.1
Date Fri, 26 Apr 2019 08:18:33 GMT
Thanks for the digestion, Zoltan. I will bullet this:

MENTORS: can you verify there's no requirement for us to put
.github/CONTRIBUTING.md (usually where it is) in the source dist?

Jorge: sorry for the bomb.. I should have warned you to note this repo
is a snowflake

-A

On Fri, Apr 26, 2019 at 5:02 PM Zoltán Nagy <abesto@apache.org> wrote:
>
> Thanks for all the context, Adrian!
>
> Agree this cleaner source distribution makes a lot of sense. Personally I'm
> OK with omitting all these files (except of course for DISCLAIMER which
> you've already added and merged into the repo). I'd be curious to hear from
> our mentors whether this is something that can be flagged on the wider vote
> as a blocker. Maybe adding a short notice to the effect of what you just
> explained to the vote announcement would help with that? But let's not get
> ahead of ourselves, let's see if this is even a problem at all.
>
> On Fri, Apr 26, 2019 at 1:04 AM Adrian Cole <adrian.f.cole@gmail.com> wrote:
>
> > spamming, but there's a lot of context with IDL.. people still
> > copy/pasta our IDL files. One good thing about having finally a source
> > distribution is we can well.. have a versioned source distribution of
> > all the IDL files needed. I'm looking forward to this as unlike
> > compiled and packaged binary projects, this particular repo stands
> > alone as source. We've never had a complete source dist here before!
> >
> > On Fri, Apr 26, 2019 at 9:01 AM Adrian Cole <adrian.f.cole@gmail.com>
> > wrote:
> > >
> > > PS it was my call to make a custom assembly for this repo. What
> > > happened before was that you could barely see the IDL files due to
> > > clutter with the dummy files needed to make a maven distribution. I
> > > would have really been confused to see this stuff, especially if I
> > > were a non java person. As the repo is for multi-language and it is an
> > > IDL project with no compilation here or otherwise, I made the
> > > judgement call to do a custom assembly.
> > >
> > > In other words, I'll help revert it if that's not acceptable. However,
> > > I think it will be detrimental to the usefulness of the distribution
> > > and possibly another user would as well.
> > >
> > > On Fri, Apr 26, 2019 at 8:48 AM Adrian Cole <adrian.f.cole@gmail.com>
> > wrote:
> > > >
> > > > Hi, Zoltan.
> > > >
> > > > The api is an IDL project only, there is nothing to build. The actual
> > > > source here is all protos, swagger and thrift IDLs.
> > > >
> > > > What's probably distracting is that we currently have a partial source
> > > > distribution in maven to depend on the protos (though we only use them
> > > > in tests).
> > > > If you ignore the ceremony files, there's only one: zipkin.proto The
> > > > zip created by this build is actually the official  and complete
> > > > source dist.
> > > >
> > > > $ jar -tvf ./target/zipkin-proto3-0.2.2-SNAPSHOT.jar
> > > >    460 Fri Apr 26 07:40:28 MYT 2019 META-INF/MANIFEST.MF
> > > >      0 Fri Apr 26 07:40:28 MYT 2019 META-INF/
> > > >      0 Fri Apr 26 07:40:28 MYT 2019 META-INF/maven/
> > > >      0 Fri Apr 26 07:40:28 MYT 2019
> > META-INF/maven/org.apache.zipkin.proto3/
> > > >      0 Fri Apr 26 07:40:28 MYT 2019
> > > > META-INF/maven/org.apache.zipkin.proto3/zipkin-proto3/
> > > >  10147 Fri Apr 26 07:40:28 MYT 2019 zipkin.proto
> > > >    263 Fri Apr 26 07:40:28 MYT 2019 META-INF/DEPENDENCIES
> > > >    170 Fri Apr 26 07:40:28 MYT 2019 META-INF/NOTICE
> > > >   9379 Fri Apr 26 07:35:26 MYT 2019
> > > > META-INF/maven/org.apache.zipkin.proto3/zipkin-proto3/pom.xml
> > > >  11358 Fri Apr 26 07:40:28 MYT 2019 META-INF/LICENSE
> > > >    112 Fri Apr 26 07:40:28 MYT 2019
> > > > META-INF/maven/org.apache.zipkin.proto3/zipkin-proto3/pom.properties
> > > >
> > > >
> > > > DISCLAIMER is missing, but I don't think CONTRIBUTING is in any way
> > > > required to be in the source dist.. a lot of it is irrelevant to a
> > > > standalone zip vs a repo root. Ex we don't contribute to a zip.
> > > >
> > > > Here's the disclaimer  stuff
> > > > https://github.com/apache/incubator-zipkin-api/pull/65
> > > >
> > > > I should have tipped off Jorge to do a REVIEW first to save some of
> > > > the recutting work by asking others to run the build like so and look
> > > > at the zip themselves GPG_TTY=$(tty) ./mvnw clean install
> > > > -Papache-release
> > > >
> > > > next time!
> > > >
> > > > -A
> > > >
> > > > On Fri, Apr 26, 2019 at 2:54 AM Zoltán Nagy <abesto@apache.org>
wrote:
> > > > >
> > > > > Sorry, I'm gonna be picky vote -1: the source archive (as well as
> > the repo,
> > > > > though that's not as important) is missing the DISCLAIMER file.
> > > > >
> > > > > I also notice there are a bunch of files/folders that are in the
git
> > repo
> > > > > at commit 1e7797f72c5132d9ccc5612de949dc3f3fe312b6, but not in the
> > source
> > > > > archive; can you confirm they're all intentional? (I'm not seeing
an
> > issue,
> > > > > just want to make sure): CONTRIBUTING.md, javadoc/, package.json,
> > pom.xml,
> > > > > src/, validate.js
> > > > >
> > > > > The comment about artifact naming from zipkin-layout-factory applies
> > here
> > > > > as well.
> > > > >
> > > > > Thank you for your work on setting up these releases!
> > > > >
> > > > > On Thu, Apr 25, 2019 at 4:02 PM Jorge Quilcate <
> > quilcate.jorge@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hello Zipkin Community,
> > > > > >
> > > > > > This is a call for vote to release Apache Zipkin API (incubating)
> > version
> > > > > > 0.2.1.
> > > > > >
> > > > > > The release candidates:
> > > > > >
> > https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-api/0.2.1/
> > > > > >
> > > > > > Git tag for the release:
> > > > > > https://github.com/apache/incubator-zipkin-api/tree/v0.2.1
> > > > > >
> > > > > > Hash for the release tag: 1e7797f72c5132d9ccc5612de949dc3f3fe312b6
> > > > > >
> > > > > > Release Notes:
> > > > > > https://github.com/apache/incubator-zipkin-api/releases/tag/v0.2.1
> > > > > >
> > > > > > The artifacts have been signed with Key : 50D90C2C, which can
be
> > found in
> > > > > > the keys file:
> > > > > > https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS
> > > > > >
> > > > > > Verification Hints:
> > > > > > For your convenience, the below includes detailed how-to on
> > verifying a
> > > > > > source release. Please note that this document is a
> > work-in-progresshttps://
> > > > > >
> > cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release
> > > > > >
> > > > > > The vote will be open for at least 72 hours or until necessary
> > number of
> > > > > > votes are reached.
> > > > > >
> > > > > > Please vote accordingly:
> > > > > >
> > > > > > [ ] +1 approve
> > > > > > [ ] +0 no opinion
> > > > > > [ ] -1 disapprove with the reason
> > > > > >
> > > > > > Thanks,
> > > > > > The Apache Zipkin (Incubating) Team
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail:dev-unsubscribe@zipkin.apache.org
> > > > > > For additional commands, e-mail:dev-help@zipkin.apache.org
> > > > > >
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> > > > > > For additional commands, e-mail: dev-help@zipkin.apache.org
> > > > > >
> > > > > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> > For additional commands, e-mail: dev-help@zipkin.apache.org
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message