zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] abesto commented on a change in pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build
Date Fri, 01 Feb 2019 10:02:22 GMT
abesto commented on a change in pull request #21: [jenkins] Snapshot phase: let's not throw
away the existing build
URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/21#discussion_r252993281
 
 

 ##########
 File path: Jenkinsfile
 ##########
 @@ -62,7 +62,7 @@ pipeline {
                 branch 'master'
             }
             steps {
-                sh './mvnw clean deploy -Papache-release -Dgpg.skip=true --batch-mode -pl
-:brave-itests'
+                sh './mvnw deploy -Papache-release -Dgpg.skip=true --batch-mode -pl -:brave-itests'
 
 Review comment:
   Ah, thank you for the explanation and sorry for my ignorance on all things Maven :D This
makes sense, especially since with your way we won't quietly build any missing dependencies,
but instead fail loudly. Which is what we want here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message