From dev-return-273-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Thu Jan 31 12:32:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EF34C180648 for ; Thu, 31 Jan 2019 13:32:01 +0100 (CET) Received: (qmail 70423 invoked by uid 500); 31 Jan 2019 12:32:01 -0000 Mailing-List: contact dev-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list dev@zipkin.apache.org Received: (qmail 70412 invoked by uid 99); 31 Jan 2019 12:32:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jan 2019 12:32:01 +0000 From: GitBox To: dev@zipkin.apache.org Subject: [GitHub] shakuzen commented on a change in pull request #15: Jenkinsfile tweaks Message-ID: <154893792057.17301.10325629605436265514.gitbox@gitbox.apache.org> Date: Thu, 31 Jan 2019 12:32:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit shakuzen commented on a change in pull request #15: Jenkinsfile tweaks URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/15#discussion_r252648597 ########## File path: Jenkinsfile ########## @@ -39,13 +56,38 @@ pipeline { sh './mvnw clean install' } } - } + /* + TODO uncomment and finish up the command here once we're ready to release snapshots + stage('Publish snapshot') { + when { + branch 'master' + } + steps { + sh './mvnw $TODO' + } + } + */ + } post { always { junit '**/target/surefire-reports/*.xml' deleteDir() } + + changed { + script { + if (env.BRANCH_NAME == 'master') { Review comment: Does this or can we distinguish between `master` on forks (e.g. some pull requests might use the master branch in their fork)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org For additional commands, e-mail: dev-help@zipkin.apache.org