zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] abesto commented on a change in pull request #15: Jenkinsfile tweaks
Date Thu, 31 Jan 2019 14:49:11 GMT
abesto commented on a change in pull request #15: Jenkinsfile tweaks
URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/15#discussion_r252696326
 
 

 ##########
 File path: Jenkinsfile
 ##########
 @@ -39,13 +56,38 @@ pipeline {
                 sh './mvnw clean install'
             }
         }
-    }
 
+        /*
+        TODO uncomment and finish up the command here once we're ready to release snapshots
+        stage('Publish snapshot') {
+            when {
+                branch 'master'
+            }
+            steps {
+                sh './mvnw $TODO'
+            }
+        }
+         */
+    }
 
     post {
         always {
             junit '**/target/surefire-reports/*.xml'
             deleteDir()
         }
+
+        changed {
+            script {
+                if (env.BRANCH_NAME == 'master') {
 
 Review comment:
   Alright, I've opened a PR to verify - #20. It seems we're fine:
   
   * Commits on my fork didn't trigger the build (as expected)
   * On the PR build the `BRANCH_NAME` env var is `PR-20`; two other env vars `CHANGE_BRANCH`
and `TARGET_BRANCH` describe the actual branches involved (see https://builds.apache.org/blue/organizations/jenkins/incubator-zipkin-brave-karaf/detail/PR-20/1/pipeline/37)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message