zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] shakuzen commented on a change in pull request #16: Switches build to Apache repositories
Date Thu, 31 Jan 2019 12:37:15 GMT
shakuzen commented on a change in pull request #16: Switches build to Apache repositories
URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/16#discussion_r252650194
 
 

 ##########
 File path: Jenkinsfile
 ##########
 @@ -57,17 +57,14 @@ pipeline {
             }
         }
 
-        /*
-        TODO uncomment and finish up the command here once we're ready to release snapshots
         stage('Publish snapshot') {
             when {
                 branch 'master'
             }
             steps {
-                sh './mvnw $TODO'
+                sh './mvnw clean deploy -Papache-release'
 
 Review comment:
   This will run the whole build again. Do we want to maybe just run the Maven Deploy Plugin's
`deploy:deploy` goal instead since the previous stage would have done the whole build except
for deploying?
   https://maven.apache.org/plugins/maven-deploy-plugin/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message