zipkin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adrian Cole <adrian.f.c...@gmail.com>
Subject Re: standard tags
Date Wed, 05 Dec 2018 02:13:14 GMT
yep. we have http.url, http.path and http.route  :)
On Wed, Dec 5, 2018 at 10:53 AM Jordi Polo Carres <jcarres@mdsol.com> wrote:
>
> Cool thanks, should we change zipkin-ruby to do http.url instead of
> http.uri then?
>
> On Wed, Dec 5, 2018 at 10:30 AM Adrian Cole <adrian.f.cole@gmail.com> wrote:
>
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__zipkin.io_public_thrift_v1_&d=DwIBaQ&c=fi2D4-9xMzmjyjREwHYlAw&r=Tbt5RfqX8JsodFyDrWf9DA8aXKZqHT-1uWccMDaGFlY&m=mf-MRvZfhxmuqRdF3BGT-8dPpbE8lMkrsYzEpZ2BYfc&s=-TihdfINTOyOFcgdByf0kan36qcvNtuAHquTmf5b6XY&e=
> > is still the source of truth. We
> > had hoped to do the same in proto3, but there is no way to create
> > constants there. We can re-evaluate and probably would be an issue for
> > either zipkin-ui repo or openzipkin.github.io repo
> > On Wed, Dec 5, 2018 at 10:02 AM Jordi Polo Carres <jcarres@mdsol.com>
> > wrote:
> > >
> > > Hi,
> > > Someone brought this question today and I could not give a satisfactory
> > > answer.
> > > Do we have a set of standard tags?
> > > I dont mean tags that must be present, but if you choose to add for
> > > instance the HTTP method, we all use the same tag for that.
> > >
> > > These
> > >
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openzipkin_zipkin-2Dgo_blob_master_tags.go&d=DwIBaQ&c=fi2D4-9xMzmjyjREwHYlAw&r=Tbt5RfqX8JsodFyDrWf9DA8aXKZqHT-1uWccMDaGFlY&m=mf-MRvZfhxmuqRdF3BGT-8dPpbE8lMkrsYzEpZ2BYfc&s=PXM5oDT_vt1PIGoZjO0dAf8O4ZUoUENZuQ_FXjq5KEI&e=
> > >
> > > Looks good but for instance Ruby client does http.uri instead of http.url
> > > and not sure if it is because the Ruby implementation needs to be updated
> > > or because there is no governance about this and each implementation has
> > > its own list.
> > >
> > >
> > >
> > > --
> > > *Jordi Polo Carres* | API bundle lead | Medidata Solutions Worldwide
> > > <http://www.mdsol.com/>
> > > Api bundle: api-bundle@mdsol.com
> > > API standard: https://learn.mdsol.com/display/CA/MCC+API+Standard+V1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> > For additional commands, e-mail: dev-help@zipkin.apache.org
> >
> >
>
> --
> *Jordi Polo Carres* | API bundle lead | Medidata Solutions Worldwide
> <http://www.mdsol.com/>
> Api bundle: api-bundle@mdsol.com
> API standard: https://learn.mdsol.com/display/CA/MCC+API+Standard+V1

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org


Mime
View raw message