From commits-return-1894-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Thu Jun 6 07:15:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 66F7618062B for ; Thu, 6 Jun 2019 09:15:08 +0200 (CEST) Received: (qmail 4366 invoked by uid 500); 6 Jun 2019 07:15:07 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 4357 invoked by uid 99); 6 Jun 2019 07:15:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jun 2019 07:15:07 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens Message-ID: <155980530742.27419.16018924244761323139.gitbox@gitbox.apache.org> Date: Thu, 06 Jun 2019 07:15:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2548: Sort out DEPENDENCIES file for zipkin-lens URL: https://github.com/apache/incubator-zipkin/issues/2548#issuecomment-499377995 Thanks @michaelsembwever and @WillemJiang I think there's still a question we need to answer, still package.json includes utilities such as the linter (eslint) which are used as binaries. These are in the section called `devDependencies`. Since there's limited time to spend on all types of work, it would be nice for a mentor to acknowledge if we must or must not hunt down even GPL usage when it is used as a binary. My assumption based on experience is we don't. For example, we don't scrutinize shell commands that include references to GPL linux tools. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services