From commits-return-1761-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Mon Jun 3 09:36:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 22F6718062F for ; Mon, 3 Jun 2019 11:36:30 +0200 (CEST) Received: (qmail 65966 invoked by uid 500); 3 Jun 2019 09:36:29 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 65957 invoked by uid 99); 3 Jun 2019 09:36:29 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jun 2019 09:36:29 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 514D28A876; Mon, 3 Jun 2019 09:36:24 +0000 (UTC) Date: Mon, 03 Jun 2019 09:36:24 +0000 To: "commits@zipkin.apache.org" Subject: [incubator-zipkin-brave] branch master updated: TraceKeys isn't actually a thing anymore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <155955458422.28885.11363200780255986012@gitbox.apache.org> From: adriancole@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-zipkin-brave X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 3aee1f0791c32a64c670f1461efa3d81d78a75c9 X-Git-Newrev: dfa3290c79aaf5bc060bc1f4aa256627fca93707 X-Git-Rev: dfa3290c79aaf5bc060bc1f4aa256627fca93707 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. adriancole pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-zipkin-brave.git The following commit(s) were added to refs/heads/master by this push: new dfa3290 TraceKeys isn't actually a thing anymore dfa3290 is described below commit dfa3290c79aaf5bc060bc1f4aa256627fca93707 Author: Adrian Cole AuthorDate: Mon Jun 3 17:36:20 2019 +0800 TraceKeys isn't actually a thing anymore --- instrumentation/http/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/instrumentation/http/README.md b/instrumentation/http/README.md index 7a75681..fd4d1af 100644 --- a/instrumentation/http/README.md +++ b/instrumentation/http/README.md @@ -33,7 +33,7 @@ httpTracing = httpTracing.toBuilder() @Override public void request(HttpAdapter adapter, Req req, SpanCustomizer customizer) { customizer.name(spanName(adapter, req)); // default span name - customizer.tag(TraceKeys.HTTP_URL, adapter.url(req)); // the whole url, not just the path + customizer.tag("http.url", adapter.url(req)); // the whole url, not just the path } }) .build();