zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] lambcode commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check
Date Mon, 17 Jun 2019 14:52:48 GMT
lambcode commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing
through health check
URL: https://github.com/apache/incubator-zipkin/pull/2632#discussion_r294338327
 
 

 ##########
 File path: zipkin/src/main/java/zipkin2/Component.java
 ##########
 @@ -38,6 +38,11 @@ public CheckResult check() {
     return CheckResult.OK;
   }
 
+  public String name() {
 
 Review comment:
   I'm okay with this change. Just want to note that the name reported by the health endpoint
will change for some components. E.g "InMemoryStorage" will become "InMemoryStorage{traceCount=123}"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message