zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing through health check
Date Fri, 14 Jun 2019 23:58:08 GMT
adriancole commented on a change in pull request #2632: Fix ThrottledStorageComponent not passing
through health check
URL: https://github.com/apache/incubator-zipkin/pull/2632#discussion_r294024257
 
 

 ##########
 File path: zipkin/src/main/java/zipkin2/Component.java
 ##########
 @@ -38,6 +38,11 @@ public CheckResult check() {
     return CheckResult.OK;
   }
 
+  public String name() {
 
 Review comment:
   please revert this method as it is adding a public method to a base type that existed for
a long time, for a single call site. We take public methods on base types more seriously here
vs other projects.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message