zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses deprecations
Date Thu, 13 Jun 2019 13:42:52 GMT
anuraaga commented on a change in pull request #2631: Updates to Armeria 0.87 and addresses
deprecations
URL: https://github.com/apache/incubator-zipkin/pull/2631#discussion_r293384143
 
 

 ##########
 File path: zipkin-collector/scribe/src/main/java/zipkin2/collector/scribe/ScribeInboundHandler.java
 ##########
 @@ -162,7 +162,7 @@ void maybeReadPayload(ChannelHandlerContext ctx) {
           buf.release();
         }
       } else {
-        returned.writeBytes(content.array(), content.offset(), content.length());
+        returned.writeBytes(content.array(), 0, content.length());
 
 Review comment:
   Just `writeBytes(content.array())`
   
   Back to my original, somewhat broken version ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message