zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] shakuzen commented on a change in pull request #2623: Clarifies storage versions supported vs tested
Date Tue, 04 Jun 2019 05:59:52 GMT
shakuzen commented on a change in pull request #2623: Clarifies storage versions supported
vs tested
URL: https://github.com/apache/incubator-zipkin/pull/2623#discussion_r290135784
 
 

 ##########
 File path: README.md
 ##########
 @@ -120,20 +126,29 @@ data layouts based on Zipkin's V1 Thrift model, as opposed to the
 simpler v2 data model currently used.
 
 #### MySQL
-The [MySQL v1](zipkin-storage/mysql-v1) component currently is only
-tested with MySQL 5.6-7. It is designed to be easy to understand, and
-get started with. For example, it deconstructs spans into columns, so
+The [MySQL v1](zipkin-storage/mysql-v1) component uses MySQL 5.6+
+features, but is tested against MariaDB 10.3.
+
+The schema was designed to be easy to understand and get started with;
+it was not designed for performance. Ex spans fields are columns, so
 you can perform ad-hoc queries using SQL. However, this component has
 [known performance issues](https://github.com/apache/incubator-zipkin/issues/1233): queries
will eventually take seconds to return
 if you put a lot of data into it.
 
+This store does not require a [job to aggregate](https://github.com/apache/incubator-zipkin-dependencies)
dependency links.
+However, running the job will improve performance.
 
 Review comment:
   It might be good to clarify that the performance improvement is only for retrieving dependency
links - that is, it won't improve overall performance of read/write on span data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message