zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adrianc...@apache.org
Subject [incubator-zipkin-brave] branch master updated: TraceKeys isn't actually a thing anymore
Date Mon, 03 Jun 2019 09:36:24 GMT
This is an automated email from the ASF dual-hosted git repository.

adriancole pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-zipkin-brave.git


The following commit(s) were added to refs/heads/master by this push:
     new dfa3290  TraceKeys isn't actually a thing anymore
dfa3290 is described below

commit dfa3290c79aaf5bc060bc1f4aa256627fca93707
Author: Adrian Cole <adriancole@users.noreply.github.com>
AuthorDate: Mon Jun 3 17:36:20 2019 +0800

    TraceKeys isn't actually a thing anymore
---
 instrumentation/http/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/instrumentation/http/README.md b/instrumentation/http/README.md
index 7a75681..fd4d1af 100644
--- a/instrumentation/http/README.md
+++ b/instrumentation/http/README.md
@@ -33,7 +33,7 @@ httpTracing = httpTracing.toBuilder()
       @Override
       public <Req> void request(HttpAdapter<Req, ?> adapter, Req req, SpanCustomizer
customizer) {
         customizer.name(spanName(adapter, req)); // default span name
-        customizer.tag(TraceKeys.HTTP_URL, adapter.url(req)); // the whole url, not just
the path
+        customizer.tag("http.url", adapter.url(req)); // the whole url, not just the path
       }
     })
     .build();


Mime
View raw message