From commits-return-1700-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Fri May 31 13:24:39 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A6CD8180627 for ; Fri, 31 May 2019 15:24:39 +0200 (CEST) Received: (qmail 79555 invoked by uid 500); 31 May 2019 13:24:38 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 79546 invoked by uid 99); 31 May 2019 13:24:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 May 2019 13:24:38 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] tmichnik1981 opened a new issue #2619: Calls server to client not visible on 'Dependencies' tree Message-ID: <155930907351.9554.14581422928062378349.gitbox@gitbox.apache.org> Date: Fri, 31 May 2019 13:24:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit tmichnik1981 opened a new issue #2619: Calls server to client not visible on 'Dependencies' tree URL: https://github.com/apache/incubator-zipkin/issues/2619 zipkin: 2.12.9 I prepared 2 short tests for zipkin2.internal.DependencyLinker for better understanding what I mean. In both cases, links **server -> client1** are missing. I there something wrong with my entry data or tests? ``` @Test public void shouldServerClientRemoteCallsWithServerDescendantBuildLinks() { List trace = asList( span2("a", null, "a", Kind.CLIENT, "client0", null, false), span2("a", "a", "b", Kind.SERVER, "server", "client0", false), span2("a", "b", "c", Kind.CLIENT, "client1", null, false), span2("a", "c", "d", Kind.SERVER, "server1", "client1", false) ); assertThat(new DependencyLinker().putTrace(trace).link()).contains( DependencyLink.newBuilder().parent("client0").child("server").callCount(1L).build(), DependencyLink.newBuilder().parent("server").child("client1").callCount(1L).build(), DependencyLink.newBuilder().parent("client1").child("server1").callCount(1L).build() ); } @Test public void shouldServerClientRemoteCallsWithClientDescendantBuildLinks() { List trace = asList( span2("a", null, "a", Kind.CLIENT, "client0", null, false), span2("a", "a", "b", Kind.SERVER, "server", "client0", false), span2("a", "b", "c", Kind.CLIENT, "client1", null, false), span2("a", "c", "d", Kind.CLIENT, "client2", null, false) ); assertThat(new DependencyLinker().putTrace(trace).link()).contains( DependencyLink.newBuilder().parent("client0").child("server").callCount(1L).build(), DependencyLink.newBuilder().parent("server").child("client1").callCount(1L).build(), DependencyLink.newBuilder().parent("client1").child("client2").callCount(1L).build() ); } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services